refactor(ckbtc): use IC CDK to interact with Bitcoin canister #2921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpahlavi
added
the
CI_ALL_BAZEL_TARGETS
lpahlavi
force-pushed
the
lpahlavi/XC-229-use-ic-cdk-for-bitcoin-canister
branch
from
f3c2cc5 to
9079874
Compare
gregorydemay
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Thanks @lpahlavi for this PR! Only some very minor comments, otherwise code looks very good to me!
|
Thank you for the review @gregorydemay, I've incorporated your feedback! |
ninegua
approved these changes
Dec 5, 2024
|
@ninegua Thank a lot for your feedback! I'd missed the built-in conversion between Network and NetworkInRequest, looks much better now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(XC-229) Interact with the Bitcoin canister through the IC CDK instead of the management canister within the ckBTC minter.