-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(crypto): CRP-2597 move MasterPublicKeyId protobuf from registry/crypto to types #2406
Merged
fspreiss
merged 7 commits into
master
from
franzstefan/CRP-2597-move-masterpublickeyid-proto-to-types
Nov 9, 2024
Merged
refactor(crypto): CRP-2597 move MasterPublicKeyId protobuf from registry/crypto to types #2406
fspreiss
merged 7 commits into
master
from
franzstefan/CRP-2597-move-masterpublickeyid-proto-to-types
Nov 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…try/crypto to types
fspreiss
added
CI_OVERRIDE_BUF_BREAKING
Skip buf-breaking (protobuf) check (explain in PR description why)
and removed
CI_OVERRIDE_BUF_BREAKING
Skip buf-breaking (protobuf) check (explain in PR description why)
labels
Nov 6, 2024
fspreiss
changed the base branch from
master
to
basvandijk/run-buf-breaking-on-proto-changes
November 6, 2024 12:06
Base automatically changed from
basvandijk/run-buf-breaking-on-proto-changes
to
master
November 6, 2024 12:35
fspreiss
added
the
CI_OVERRIDE_BUF_BREAKING
Skip buf-breaking (protobuf) check (explain in PR description why)
label
Nov 6, 2024
fspreiss
requested review from
eichhorl,
Sawchord,
alin-at-dfinity,
aterga and
maksymar
November 6, 2024 14:13
max-dfinity
approved these changes
Nov 7, 2024
eichhorl
approved these changes
Nov 7, 2024
dragoljub-duric
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/rs/replicated_state
and /rs/types/management_canister_types
LGTM.
randombit
approved these changes
Nov 7, 2024
alin-at-dfinity
approved these changes
Nov 8, 2024
fspreiss
deleted the
franzstefan/CRP-2597-move-masterpublickeyid-proto-to-types
branch
November 9, 2024 22:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI_OVERRIDE_BUF_BREAKING
Skip buf-breaking (protobuf) check (explain in PR description why)
@consensus
@crypto-team
@execution
@ic-interface-owners
@ic-message-routing-owners
@nns-team
refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
MasterPublicKeyId
Protocol Buffers message definition, and subsequently also the containedEcdsaCurve
,EcdsaKeyId
,SchnorrAlgorithm
,SchnorrKeyId
,VetKdCurve
,VetKdKeyId
definitions from theregistry.crypto.v1
package to thetypes.v1
package, without making any changes to the types in the process.This step is necessary so that we can later add an
optional MasterPublicKeyId key_id = 6;
field to thetypes.v1.NiDkgId
message. Without the move, this would create a circular dependency betweenregistry/crypto/v1/crypto.proto
andtypes/v1/types.proto
becauseregistry/crypto/v1.crypto.proto
importstypes/v1/types.proto
(so as to usetypes.v1.SubnetId
in theChainKeySigningSubnetList
);Given that all message definitions remain unchanged and we only change the package, the wire format of the messages is unchanged, which should make this change safe. However, changes like this lead to the
//pre-commit:buf-breaking
test to fail (even thoughbuf.yaml
is configured to use WIRE), which is a known deficiancy in the underlyingbuf
compatibility-check library: bufbuild/buf#2318. Because of this, we set theCI_OVERRIDE_BUF_BREAKING
flag to override this.