Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: node signature verification for queries #784

Merged
merged 36 commits into from
Nov 7, 2023
Merged

feat: node signature verification for queries #784

merged 36 commits into from
Nov 7, 2023

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Oct 20, 2023 •
edited
Loading

Description

In order to defend against malicious boundary nodes, subnet nodes will sign query responses. An Agent should follow the Internet Computer specification to validate these signatures

Fixes SDK-1216

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock changed the title Kyle/sdk 1216 node signature verification feat: node signature verification for queries Oct 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/agent 98.18 KB (+10.97% 🔺)
@dfinity/candid 13.41 KB (-1.37% 🔽)
@dfinity/principal 5.01 KB (-3.68% 🔽)
@dfinity/auth-client 90.53 KB (-2.34% 🔽)
@dfinity/assets 91.07 KB (+0.27% 🔺)
@dfinity/identity 88.01 KB (-2.19% 🔽)
@dfinity/identity-secp256k1 249.41 KB (+6.68% 🔺)

@krpeacock
Copy link
Contributor Author

oh thank god

@krpeacock krpeacock marked this pull request as ready for review November 6, 2023 20:19
@krpeacock krpeacock requested a review from a team as a code owner November 6, 2023 20:19
@krpeacock
fix: sets maxAge for delegation certificates to
7cf9f9f 
Infinity, bypassing check
resolves FOLLOW-1302
@krpeacock krpeacock enabled auto-merge (squash) November 7, 2023 18:45
@krpeacock krpeacock merged commit c115480 into main Nov 7, 2023
14 checks passed
@krpeacock krpeacock deleted the kyle/SDK-1216-node-signature-verification branch November 7, 2023 19:16
@krpeacock krpeacock mentioned this pull request Dec 5, 2023
Closed
This was referenced Sep 6, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfx-json dfx-json dfx-json approved these changes

@roelstorms roelstorms Awaiting requested review from roelstorms

@ShuoWangNSL ShuoWangNSL Awaiting requested review from ShuoWangNSL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krpeacock @roelstorms @ShuoWangNSL @dfx-json