feat: certificate time checks #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…han 5 minutes ahead of or behind system time
size-limit report 📦
|
provides mechanism for verifying the max age so that delegations can be signed up to 30 days in advance and will still validate correctly.
ericswanson-dfinity
requested changes
Sep 15, 2023
ericswanson-dfinity
approved these changes
Sep 15, 2023
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The time on certificates returned by read_state requests is currently not checked in agent-js.
It is a good practice to check the time to avoid using stale data. For example, we do it for asset certification in the service worker because otherwise a malicious node could serve stale/outdated HTTP assets.
Fixes SDK-1132
How Has This Been Tested?
new unit tests with mocked time and custom errors
Checklist: