Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add @dfinity/principal as a peerDependency where needed #752

Merged
merged 3 commits into from
Aug 15, 2023
Merged

fix: add @dfinity/principal as a peerDependency where needed #752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
310ca0a
fix: add `@dfinity/principal` as a peerDependency where needed
hpeebles Aug 15, 2023
fd6a88d
Merge branch 'main' of github.com:dfinity/agent-js
hpeebles Aug 15, 2023
5847bc8
Update changelog
hpeebles Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/generated/changelog.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ <h1>Agent-JS Changelog</h1>
<section>
<h2>Version x.x.x</h2>
<ul>
<li>Fix: add `@dfinity/principal` as a peerDependency to `assets` and `candid`.</li>
<li>
Feat: HttpAgent now uses a default address of https://icp-api.io. Users will be warned for
not setting a host, but the code will default to mainnet.
Expand Down
4 changes: 4 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/assets/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
},
"peerDependencies": {
"@dfinity/agent": "^0.18.1",
"@dfinity/principal": "^0.18.1",
"js-sha256": "0.9.0"
},
"dependencies": {
Expand Down
3 changes: 3 additions & 0 deletions packages/candid/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@
"test": "jest",
"test:coverage": "jest --verbose --collectCoverage"
},
"peerDependencies": {
"@dfinity/principal": "^0.18.1"
},
"devDependencies": {
"@types/jest": "^28.1.4",
"@typescript-eslint/eslint-plugin": "^5.30.5",
Expand Down
Loading