chore: replaces use of localhost with 127.0.0.1 for better node 18 su…

…pport
dfinity · Oct 26, 2023 · d13c868 · d13c868
1 parent 75fcb03
commit d13c868
Show file tree

Hide file tree

Showing 13 changed files with 127 additions and 104 deletions.
diff --git a/demos/sample-javascript/README.md b/demos/sample-javascript/README.md
@@ -6,4 +6,4 @@
 
 1. Ensure all dependencies are installed: `npm install`
 2. Run the development server `npm run develop`
-3. Visit the running site at http://localhost:8080
+3. Visit the running site at http://127.0.0.1:8080
diff --git a/docs/generated/changelog.html b/docs/generated/changelog.html
@@ -12,6 +12,7 @@ <h1>Agent-JS Changelog</h1>
     <section>
       <h2>Version x.x.x</h2>
       <ul>
+        <li>chore: replaces use of localhost with 127.0.0.1 for better node 18 support</li>
         <li>feat: retry logic will catch and retry for thrown errors</li>
         <li>
           feat!: adds certificate logic to decode subnet and node key paths from the hashtree.

diff --git a/e2e/browser/.proxyrc b/e2e/browser/.proxyrc
@@ -1,5 +1,5 @@
 {
   "/api": {
-    "target": "http://localhost:4943/",
+    "target": "http://127.0.0.1:4943/",
   }
 }
diff --git a/e2e/node/basic/canisterStatus.test.ts b/e2e/node/basic/canisterStatus.test.ts
@@ -9,7 +9,7 @@ afterEach(async () => {
 describe('canister status', () => {
   it('should fetch successfully', async () => {
     const counterObj = await (await counter)();
-    const agent = new HttpAgent({ host: `http://localhost:${process.env.REPLICA_PORT}` });
+    const agent = new HttpAgent({ host: `http://127.0.0.1:${process.env.REPLICA_PORT}` });
     await agent.fetchRootKey();
     const request = await CanisterStatus.request({
       canisterId: Principal.from(counterObj.canisterId),
@@ -21,7 +21,7 @@ describe('canister status', () => {
   });
   it('should throw an error if fetchRootKey has not been called', async () => {
     const counterObj = await (await counter)();
-    const agent = new HttpAgent({ host: `http://localhost:${process.env.REPLICA_PORT}` });
+    const agent = new HttpAgent({ host: `http://127.0.0.1:${process.env.REPLICA_PORT}` });
     const shouldThrow = async () => {
       // eslint-disable-next-line no-useless-catch
       try {

diff --git a/e2e/node/canisters/counter.ts b/e2e/node/canisters/counter.ts
@@ -84,7 +84,7 @@ export async function noncelessCanister(): Promise<{
 
 export const createActor = async (options?: HttpAgentOptions) => {
   const module = readFileSync(path.join(__dirname, 'counter.wasm'));
-  const agent = new HttpAgent({ host: `http://localhost:${process.env.REPLICA_PORT}`, ...options });
+  const agent = new HttpAgent({ host: `http://127.0.0.1:${process.env.REPLICA_PORT}`, ...options });
   await agent.fetchRootKey();
 
   const canisterId = await Actor.createCanister({ agent });

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/agent/README.md b/packages/agent/README.md
@@ -86,7 +86,7 @@ For example,
 import fetch from 'isomorphic-fetch';
 import { HttpAgent } from '@dfinity/agent';
 
-const host = process.env.DFX_NETWORK === 'local' ? 'http://localhost:4943' : 'https://icp-api.io';
+const host = process.env.DFX_NETWORK === 'local' ? 'http://127.0.0.1:4943' : 'https://icp-api.io';
 
 const agent = new HttpAgent({ fetch, host });
 ```
@@ -99,7 +99,7 @@ For example,
 import fetch from 'isomorphic-fetch';
 import { HttpAgent } from '@dfinity/agent';
 
-const host = process.env.DFX_NETWORK === 'local' ? 'http://localhost:4943' : 'https://ic0.app';
+const host = process.env.DFX_NETWORK === 'local' ? 'http://127.0.0.1:4943' : 'https://ic0.app';
 
 /**
  * @type {RequestInit}