Merge branch 'main' into kai/multi-actor

dfinity · Sep 9, 2024 · b303893 · b303893
2 parents 5c0eef3 + 7e992e3
commit b303893
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -15,6 +15,9 @@
 - docs: documentation and metadata for use-auth-client
 - feat: adds optional `rootKey` to `HttpAgentOptions` to allow for a custom root key to be used for verifying signatures from other networks
 - chore: npm audit bumping micromatch
+- feat: exports polling utilities from `@dfinity/agent` for use in other packages
+  - `pollForResponse` now uses the default strategy by default
+  - Updated the `bls-verify` jsdoc comment to accurately reflect that the default strategy now uses @noble/curves
 - docs: clarifies meaning of `effectiveCanisterId` in `CallOptions`
 
 ### Changed

diff --git a/packages/agent/src/certificate.ts b/packages/agent/src/certificate.ts
@@ -135,7 +135,7 @@ export interface CreateCertificateOptions {
    */
   canisterId: Principal;
   /**
-   * BLS Verification strategy. Default strategy uses wasm for performance, but that may not be available in all contexts.
+   * BLS Verification strategy. Default strategy uses bls12_381 from @noble/curves
    */
   blsVerify?: VerifyFunc;
 

diff --git a/packages/agent/src/index.ts b/packages/agent/src/index.ts
@@ -29,6 +29,7 @@ import { Agent, HttpAgent } from './agent';
 import { IDL } from '@dfinity/candid';
 
 export * as Cbor from './cbor';
+export * from './polling';
 
 export interface GlobalInternetComputer {
   ic: {

diff --git a/packages/agent/src/polling/index.ts b/packages/agent/src/polling/index.ts
@@ -5,6 +5,7 @@ import { RequestId } from '../request_id';
 import { toHex } from '../utils/buffer';
 
 export * as strategy from './strategy';
+import { defaultStrategy } from './strategy';
 export { defaultStrategy } from './strategy';
 export type PollStrategy = (
   canisterId: Principal,
@@ -27,7 +28,7 @@ export async function pollForResponse(
   agent: Agent,
   canisterId: Principal,
   requestId: RequestId,
-  strategy: PollStrategy,
+  strategy: PollStrategy = defaultStrategy(),
   // eslint-disable-next-line
   request?: any,
   blsVerify?: CreateCertificateOptions['blsVerify'],