Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes spm support #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes spm support #79

wants to merge 1 commit into from

Conversation

AndrewSB
Copy link

No description provided.

@MainasuK
Copy link

MainasuK commented Aug 12, 2020

The current master does not work in Xcode 11.6 with SwiftPM. And also this PR not working.

I believe the header moves to /include will be better. If not change the folder structure. The puclicHeadersPath should be "" empty string. SwiftPM in Xcode 11.6 not accepts "." or nil.

Here is my folk.
MainasuK@20f513d

@AndrewSB
Copy link
Author

Screen Shot 2020-08-14 at 8 58 08 AM

I've been using my fork for a few weeks on Xcode 11.6 and the beta 12. Are you sure you're targeting the right branch (AndrewSB/master) in your package manifest?

@MainasuK
Copy link

You are right. I'm not change the checkout rules to "branch". After switch to master the package works.

@MalcolmnDEV
Copy link

@AndrewSB I am getting this error now on Xcode 12 :

Value of type 'UITextView' has no member 'placeholder'

@AndrewSB
Copy link
Author

AndrewSB commented Sep 23, 2020

Could you provide more context around the error please? The full compiler message if you can see it? I haven't downloaded 12 yet.

I'm also more than happy to accept a PR that fixes the issue if you'd like to patch it!

@MalcolmnDEV
Copy link

@AndrewSB Thats the only error message that Xcode gives.

Do you think it might be around objective c files inside the package ?

@MalcolmnDEV
Copy link

I am trying to access optionTextField.placeholder = ""

This is where the error comes

@AndrewSB
Copy link
Author

I can't really tell what might the problem without more context. I can take a look in a couple weeks when I upgrade to Xcode 12

@tangbl93
Copy link

tangbl93 commented Jan 6, 2021

it's works for me

@MalcolmnDEV
Copy link

I still get an error on Xcode 12.2.

Value of type 'UITextView' has no member 'placeholder'

@MalcolmnDEV
Copy link

Its as if the package does not include placeholder

@4brunu
Copy link

4brunu commented Feb 18, 2021

This is working for me.

@4brunu
Copy link

4brunu commented Jun 16, 2021

This PR is working, but Xcode is showing the following warning:
/Users/user/Library/Developer/Xcode/DerivedData/Project-beynuwyvodgnkhfdlxfcwaisrsll/SourcePackages/checkouts/UITextView-Placeholder/Sources/include/UITextView+Placeholder.h should be renamed to /Users/user/Library/Developer/Xcode/DerivedData/Project-beynuwyvodgnkhfdlxfcwaisrsll/SourcePackages/checkouts/UITextView-Placeholder/Sources/include/UITextView_Placeholder.h to be used as an umbrella header

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants