-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore karma tokens inside code blocks #547
Open
raerpo
wants to merge
3
commits into
devschile:master
Choose a base branch
from
raerpo:bugfix/karma-code
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+29
−0
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -156,6 +156,19 @@ module.exports = robot => { | |
return tokens.filter(token => urls.reduce((acc, url) => acc && url.indexOf(token) === -1, true)) | ||
} | ||
|
||
// Sometimes we want to use code that contains ++ or --. This function allow us | ||
// to find the text that is inside code blocks so we can compare and avoid false positives | ||
// in karma assignation. | ||
const findTextInsideCodeBlocks = message => { | ||
const regex = /`(.*?)`/g | ||
let matches = [] | ||
let match | ||
while ((match = regex.exec(message)) !== null) { | ||
matches.push(match[0]) | ||
} | ||
Comment on lines
+166
to
+168
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no sería mejor usar un mecanismo tipo Encuentro que darle con el while es como darse muchas vueltas |
||
return matches | ||
} | ||
|
||
robot.hear(/([a-zA-Z0-9-_\.]|[^\,\-\s\+$!(){}"'`~%=^:;#°|¡¿?]+?)(\b\+{2}|-{2})([^,]?|\s|$)/g, response => { | ||
stripRegex = /~!@#$`%^&*()|\=?;:'",<>\{\}/gi | ||
const tokens = removeURLFromTokens(response.match, response.message.text) | ||
|
@@ -164,7 +177,13 @@ module.exports = robot => { | |
if (!robot.adapter.client.rtm.dataStore.getChannelGroupOrDMById(response.envelope.room).is_channel) return | ||
} | ||
|
||
const codeBlocks = findTextInsideCodeBlocks(response.message.text) | ||
|
||
tokens | ||
.filter(token => { | ||
// If the token match with a codeBlock it is remove from the karma assignation | ||
return codeBlocks.filter(codeBlock => codeBlock.includes(token)).length === 0 | ||
}) | ||
.slice(0, 5) | ||
.map(token => { | ||
const opRegex = /(\+{2}|-{2})/g | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cual es el beneficio de este
let
?