Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LRU cleanup for generic repositories #151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AJIOB
Copy link

@AJIOB AJIOB commented Nov 26, 2024

Implements suggestion from #130


```yaml
- rule: DeleteLeastRecentlyUsedFiles
keep_at_most_mb: 512
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should combine LRU and sized rule here.
Almost all rules right now works on "number of files" idea - so for LRU it'd be something like

- rule: DeleteLeastRecentlyUsedFiles
  keep: 10

where 10 - number of artifacts.

Imagine the case when you setup 512MB limit with regular size for each artifact for 10Mb.
But accidentally, you put some large zip/deb/msi in the repo, like 640Mb.
The rule with Mb will remove all other artifacts, but will keep only the last one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants