fix: schema of type string shows defaults when cleared (rjsf-team#1505)

* fix: schema of type string shows defaults when cleared * feat: add unit test * Update test/StringField_test.js Co-Authored-By: Ashwin Ramaswami <[email protected]>
devo-wm · Dec 7, 2019 · e673a90 · e673a90
1 parent 4f02482
commit e673a90
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/packages/core/src/utils.js b/packages/core/src/utils.js
@@ -301,7 +301,7 @@ export function getDefaultFormState(
   if (isObject(formData) || Array.isArray(formData)) {
     return mergeDefaultsWithFormData(defaults, formData);
   }
-  if (formData === 0 || formData === false) {
+  if (formData === 0 || formData === false || formData === "") {
     return formData;
   }
   return formData || defaults;

diff --git a/packages/core/test/StringField_test.js b/packages/core/test/StringField_test.js
@@ -200,6 +200,21 @@ describe("StringField", () => {
       expect(comp.state.formData).eql("default");
     });
 
+    it("should handle an empty string change event with defaults set", () => {
+      const { comp, node } = createFormComponent({
+        schema: {
+          type: "string",
+          default: "a",
+        },
+      });
+
+      Simulate.change(node.querySelector("input"), {
+        target: { value: "" },
+      });
+
+      expect(comp.state.formData).eql(undefined);
+    });
+
     it("should fill field with data", () => {
       const { node } = createFormComponent({
         schema: {