Install multiple binaries from an archive asset #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
extract |
devmatteini
requested changes
Nov 2, 2024
There was a problem hiding this comment.
Hi @duong-dt and thanks for your contribution 😄!
I left some comments to check out :)
…r input validation
…hen multiple install targets are specified
…not_dir inside maybe_install
…archive which are not needed The same checks are already done by installer::install.
devmatteini
force-pushed
the
multiple-bin
branch
from
60da230
to
362983a
Compare
|
The work for this new feature is not done yet, but I think it's ok to merge this initial work. Thanks @duong-dt for your initial implementation! |
|
Sorry I was too busy last few weeks, and cannot make further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support installing multiple binaries from an archive asset #234 , without having to download such asset multiple times, by accepting multiple
-I,--install-filearguments.-I,--install-fileare specified, and-o,--outputis specified, then-o,--outputmust be a directory.-I,--install-fileare specified, the selected asset (either specified by-s,--selector via by-a,--automatic) must be an archive asset.