-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coreinit: add stopwatch.h and stopwatchatomic.h #370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some style nitpicks. Also try to use 3 spaces for indentation like the other headers.
include/coreinit/stopwatchatomic.h
Outdated
* Get the current time on the stopwatch | ||
* \returns current time on stopwatch | ||
*/ | ||
OSTime OSStopWatchLap(OSStopWatchAtomic *stopWatch); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing newline after the return type.
include/coreinit/stopwatchatomic.h
Outdated
|
||
typedef struct OSStopWatchAtomic OSStopWatchAtomic; | ||
|
||
struct OSStopWatchAtomic { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
struct OSStopWatchAtomic { | |
struct OSStopWatchAtomic | |
{ |
include/coreinit/stopwatch.h
Outdated
|
||
typedef struct OSStopwatch OSStopwatch; | ||
|
||
struct OSStopwatch { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
struct OSStopwatch { | |
struct OSStopwatch | |
{ |
include/coreinit/stopwatch.h
Outdated
//! Lock | ||
OSSpinLock lock; | ||
//! Tag | ||
char* name; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
char* name; | |
const char* name; |
Co-authored-by: GaryOderNichts <[email protected]>
* coreinit: add stopwatch.h and stopwatchatomic.h * Formatting * correct function name
Adds the stopwatch functions and structs.
Named what should be
OSStopWatch
toOSStopWatchAtomic
to avoid confusion withOSStopwatch