Feature | OECD Mums #826
Feature | OECD Mums #826
Conversation
There was a problem hiding this comment.
Hi @dean-breed, can we keep all external files i.e CSVs, zips, txt files etc at this repo?
https://github.com/devinit/ddw-data-update-configs/
Also, please rename the file and remove spaces. Let's use underscores instead.
|
@wakibi I can do both of those things but do I need to make any resulting changes due to the data being located differently? |
|
@wakibi As for the filename, I generally prefer leaving it the same as the source to make traceability more clear but if the code really needs it to not have spaces, we can do that also. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
I'm reopening this as I'm sure it had value - should have been check once the stale bot tagged it for closing. |
|
Guess you'll have to take this all the way @wakibi |
edwinmp
force-pushed
the
feature/oecd-mums
branch
from
21d2e6e to
40a82d8
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## develop #826 +/- ##
============================================
+ Coverage 46.33% 56.89% +10.55%
============================================
Files 195 129 -66
Lines 7059 1965 -5094
Branches 522 522
============================================
- Hits 3271 1118 -2153
+ Misses 3684 743 -2941
Partials 104 104 see 66 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Mums and SDG for DDW next deployment. Ticket #684