Feature | Query Estimate

[wakibi]

Issue #260

[codecov-commenter]

Codecov Report

Merging #549 (d4fbbff) into develop (e4ae5c7) will decrease coverage by 0.65%.
The diff coverage is 6.41%.

@@             Coverage Diff             @@
##           develop     #549      +/-   ##
===========================================
- Coverage    63.06%   62.40%   -0.66%     
===========================================
  Files          161      162       +1     
  Lines         4900     4950      +50     
  Branches       447      447              
===========================================
- Hits          3090     3089       -1     
- Misses        1805     1856      +51     
  Partials         5        5              

Impacted Files	Coverage Δ
core/serializers.py	57.65% <ø> (ø)
core/urls.py	100.00% <ø> (ø)
data/db_manager.py	31.16% <0.00%> (-0.84%)	⬇️
...ata/management/commands/dry_run_current_queries.py	0.00% <0.00%> (ø)
...management/commands/update_query_estimate_times.py	0.00% <0.00%> (ø)
core/tasks.py	15.27% <16.66%> (+0.27%)	⬆️
core/models.py	88.82% <100.00%> (+0.05%)	⬆️
core/views.py	39.22% <100.00%> (+0.33%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4ae5c7...d4fbbff. Read the comment docs.

[edwinmp]

@wakibi please verify that this behaves as you expect on staging ... compare with the current behaviour and see if it's an improvement ... I had trouble seeing the expected root behaviour i.e. the query estimate. Let me know how to replicate it. My worry is that we've now optimised the behaviour so well that there's barely a delay, especially since we paginate the results. Anyway, let me know if you find a particularly slow query where the true value of this feature can be demonstrated.

[edwinmp]

This isn't doing what its supposed to, even for new queries. It's also adding overhead that's slowed things down a bit. We can fix this & the UX in subsequent reviews, but the main thing is that its not behaving as expected.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.