rename /crop endpoints to /bbox or /feature #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Sep 27, 2023
src/titiler/core/pyproject.toml
Outdated
| @@ -33,7 +33,8 @@ dependencies = [ | |||
| "geojson-pydantic>=1.0,<2.0", | |||
| "jinja2>=2.11.2,<4.0.0", | |||
| "numpy", | |||
| "pydantic~=2.0", | |||
| # https://github.com/pydantic/pydantic/pull/7653 | |||
| "pydantic==2.3", | |||
There was a problem hiding this comment.
ref #703
This will be fixed with pydantic 2.4.2
vincentsarago
commented
Sep 27, 2023
| @@ -320,6 +320,20 @@ def __post_init__(self): | |||
| self.max_size = None | |||
|
|
|||
|
|
|||
| @dataclass | |||
| class PartFeatureParams(DefaultDependency): | |||
There was a problem hiding this comment.
New Dependency for /bbox, /feature and /statistics [POST] endpoint where we don't set max_size default
There was a problem hiding this comment.
PartFeatureParams is a confusing name but I can't really thing of anything better myself 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #702
This PR does:
/cropendpoints to both/bboxand/featureendpoint breakingimg_dependencywithimg_preview_dependencyandimg_part_dependencybreaking1024default formax_sizewhen usingbboxandfeatureendpoints