-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: STAC Render Extension support #1038
Open
alekzvik
wants to merge
10
commits into
developmentseed:main
Choose a base branch
from
alekzvik:feat-stac-render-extension
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
529d864
Render Extension
emmanuelmathot e20dfef
feat(stac): add render extenstions support
alekzvik c63a482
remove unnecessary item.json file
alekzvik 3f10def
Rework the response structure to include links.
alekzvik 9904786
rename renderExtension -> stacRenderExtension
alekzvik a7121b2
add tests for stacRenderExtension
alekzvik 3e9995e
add test for extra param
alekzvik 767c31d
docs and docstrings
alekzvik 46b13ee
fix typing in python 3.8
alekzvik 8dbdcf6
Move out query params validation
alekzvik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
"""test /COG endpoints.""" | ||
"""test /stac endpoints.""" | ||
|
||
|
||
from typing import Dict | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
"""Test utils.""" | ||
|
||
|
||
from titiler.core.dependencies import BidxParams | ||
from titiler.core.utils import deserialize_query_params, get_dependency_query_params | ||
|
||
|
||
def test_get_dependency_params(): | ||
"""Test dependency filtering from query params.""" | ||
|
||
# invalid | ||
values, err = get_dependency_query_params( | ||
dependency=BidxParams, params={"bidx": ["invalid type"]} | ||
) | ||
assert values == {} | ||
assert err | ||
assert err == [ | ||
{ | ||
"input": "invalid type", | ||
"loc": ( | ||
"query", | ||
"bidx", | ||
0, | ||
), | ||
"msg": "Input should be a valid integer, unable to parse string as an integer", | ||
"type": "int_parsing", | ||
}, | ||
] | ||
|
||
# not in dep | ||
values, err = get_dependency_query_params( | ||
dependency=BidxParams, params={"not_in_dep": "no error, no value"} | ||
) | ||
assert values == {"indexes": None} | ||
assert not err | ||
|
||
# valid | ||
values, err = get_dependency_query_params( | ||
dependency=BidxParams, params={"bidx": [1, 2, 3]} | ||
) | ||
assert values == {"indexes": [1, 2, 3]} | ||
assert not err | ||
|
||
# valid and not in dep | ||
values, err = get_dependency_query_params( | ||
dependency=BidxParams, | ||
params={"bidx": [1, 2, 3], "other param": "to be filtered out"}, | ||
) | ||
assert values == {"indexes": [1, 2, 3]} | ||
assert not err | ||
|
||
|
||
def test_deserialize_query_params(): | ||
"""Test deserialize_query_params.""" | ||
# invalid | ||
res, err = deserialize_query_params( | ||
dependency=BidxParams, params={"bidx": ["invalid type"]} | ||
) | ||
print(res) | ||
assert res == BidxParams(indexes=None) | ||
assert err | ||
|
||
# valid | ||
res, err = deserialize_query_params( | ||
dependency=BidxParams, params={"not_in_dep": "no error, no value", "bidx": [1]} | ||
) | ||
assert res == BidxParams(indexes=[1]) | ||
assert not err |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice the addition of
QueryParams
here.The reason is that
request_params_to_args
expects to see the result of this function.An example that helped me catch it is
rescale
param - link to def.If I pass things directly from STAC
renders
block, it would not pass validation, since it is defined as[float]
To mitigate this, I first serialize params to the state that fastapi would receive them, and then deserialize how it would do it.