[WIP]Smoke test js #61
Conversation
There was a problem hiding this comment.
@jsparmani this PR needs some changes.
- We never upload the coverage reports to the Github as they change every time a user runs the tests. So you need to add the entire coverage folder to .gitignore.
- We need to make a folder named tests under frontend, which should contain all the tests.
Okay, will work on these changes |
| CONTRIBUTION.md | ||
| Frontend/coverage |
There was a problem hiding this comment.
Instead of ignoring the directory that is being formed, we can ignore the following files
- coverage
- coverage.xml
- .coverage
Also is it possible to shift tests in the root directory? Ideally, the path of test files should be -
./tests/frontend/
There was a problem hiding this comment.
Also, do add a single end line at the end of the file
There was a problem hiding this comment.
Instead of ignoring the directory that is being formed, we can ignore the following files
- coverage
- coverage.xml
- .coverage
Also is it possible to shift tests in the root directory? Ideally, the path of test files should be -
./tests/frontend/
React isn't detecting any test files outside the src/ folder. It's their rule to reside test files in src/ folder. Looking if I find any tweak for this.
| @@ -18,6 +18,7 @@ jobs: | |||
| - yarn install --frozen-lockfile | |||
| script: | |||
| - yarn format | |||
| - yarn test -- --coverage | |||
There was a problem hiding this comment.
it's to print the coverage result, that tabular output
| @@ -0,0 +1,3 @@ | |||
| import { configure } from "enzyme"; | |||
There was a problem hiding this comment.
Can we have this in the frontend tests folder itself instead of one level above?
|
@all-contributors please add @jsparmani for code,design,maintenance |
|
I couldn't determine any contributions to add, did you specify any contributions? |
|
@all-contributors please add @jsparmani for code, design, and maintenance |
|
I've put up a pull request to add @jsparmani! 🎉 |
|
@all-contributors please add @aniketbiswas21 for code, design, and maintenance |
|
I've put up a pull request to add @aniketbiswas21! 🎉 |
|
@all-contributors please add @shubhank-saxena for design and maintenance |
|
I've put up a pull request to add @shubhank-saxena! 🎉 |
|
@all-contributors please add @animesh-007 for docs |
|
I've put up a pull request to add @animesh-007! 🎉 |
|
Status @jsparmani |
React isn't detecting any test files outside the |
|
@jsparmani would suggest you to install jest instead of the default testing, I think this issue would be solved. You will have to just add the script for test |
Fix #56