Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

리뷰 페이지 작성 #97

Merged
merged 10 commits into from
Jan 11, 2024
Merged

리뷰 페이지 작성 #97

merged 10 commits into from
Jan 11, 2024

Conversation

YOOJS1205
Copy link
Collaborator

PR의 목적을 알려주세요.

close #83

어떤 변경사항이 있는지 알려주세요.

희수님이 이미지 프리뷰 api 완성하신 것 같아서 docs 배포되면 개발할게영

중점적으로 봐주었으면 하는 부분

@YOOJS1205 YOOJS1205 added the feat New feature or request label Jan 8, 2024
@YOOJS1205 YOOJS1205 self-assigned this Jan 8, 2024
@YOOJS1205 YOOJS1205 linked an issue Jan 8, 2024 that may be closed by this pull request
Copy link
Collaborator

@y00eunji y00eunji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflict만 해결해주세욤~

<h1 className="header-22 py-[16px]">
가게 이름에 <br />
<strong className="text-primary-500">NN번째</strong> 방문이에요!
</h1>
Copy link
Collaborator

@YelynnOh YelynnOh Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기는 나중에 서버에서 보내주는 가게 이름 데이터랑 방문 수 데이터로 대체할 예정이신걸까용?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 서버랑 얘기해봐야해서... 아마 저희가 데이터 물고 페이지 넘어가야하지 않을까 싶어서 일단 뒀습니다...

Copy link
Collaborator

@YelynnOh YelynnOh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다아아~!!:)

@YOOJS1205 YOOJS1205 merged commit 438b60a into main Jan 11, 2024
2 checks passed
@YOOJS1205 YOOJS1205 deleted the feature/#83 branch January 11, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

리뷰 페이지 작성
3 participants