#192 feat: 로그아웃, 회원 탈퇴 시 쿠키 날린 거 앱으로 전달하는 로직 추가 #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YelynnOh
requested review from
sjoleee,
y00eunji and
YOOJS1205
as code owners
YOOJS1205
approved these changes
Jan 31, 2024
src/hooks/useWebView.ts
Outdated
| @@ -8,6 +8,7 @@ const useWebView = () => { | |||
| const accessToken = Cookies.get('accessToken'); | |||
| const refreshToken = Cookies.get('refreshToken'); | |||
|
|
|||
| //NOTE: 사용자가 앱을 껐다가 다시 접속할 때는 브라우저 토큰 보낼 필요 없음 | |||
| if (accessToken != null && refreshToken != null) { | |||
There was a problem hiding this comment.
비교 조건을 엄격 비교 (!==)로 하면 좋을 것 같습니다.
토큰 값이 null 혹은 string이라면 아래와 같이 작성할 수 있을 것 같네요.
if (accessToken && refreshToken) { ... }There was a problem hiding this comment.
2d07aca 넵넵 여기 반영했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR의 목적을 알려주세요.
close #192
어떤 변경사항이 있는지 알려주세요.
회원 탈퇴와 로그아웃 시 웹에서 앱으로 빈 토큰 값을 넘겨주는 부분을 추가했습니다.
중점적으로 봐주었으면 하는 부분