-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(*): GlobalStyles(Reset) 및 RootLayout 적용 #61
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semnil5202
requested review from
Doeunnkimm,
LeeJeongHooo,
Andrevile and
sambad-adventure
as code owners
July 17, 2024 19:45
docs 라벨이 왜 자꾸 붙지..? |
Andrevile
previously approved these changes
Jul 19, 2024
Andrevile
force-pushed
the
feat/SAMBAD-109
branch
from
July 19, 2024 12:45
7a963e9
to
7a5ec59
Compare
Doeunnkimm
approved these changes
Jul 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GlobalStyles로 가져가는 것이 저희가 선정한 아키텍처에서 더 적합하다고 판단
오 ^ 이부분 자세히 무슨 내용인지 궁금해서.. 나중에 여쭤볼게영 고우 ~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 변경 사항
maxWidth: 600px
로 두었고margin: 0 auto
적용하여 가운데 정렬 해두었습니다.의논 필요한 부분
[의논할 내용 요약]
injectGlobal
로 적용reset.css를 적용하는 방법이 css 파일을 import 하는 방법과, Emotion GlobalStyles를 활용하는 방법이 있는데, 결과적으로 두 방법은 거의 동일한 결과를 낸다고 생각합니다. 다만, GlobalStyles로 가져가는 것이 저희가 선정한 아키텍처에서 더 적합하다고 판단 (Web Domains의 Providers에 위치하도록 한다면) 하여 GlobalStyles로 두었습니다.
추가로 보통 사용하는 <Global styles={} /> 방식이 아닌,
injectGlobal
을 사용했습니다. 조금 더 최신의 방법이고 컴포넌트 렌더링 주기 바깥에 적용할 수 있어 font 리렌더링 이슈를 해결하는 것으로 보이는군요. (제 생각입니다.) 다만, 이로 인해서@emotion/css
의존성이 추가로 설치됐습니다. 이 부분에 대해서 추가로 의견 부탁드립니다.🔗 링크
🙏 작업물 스크린샷