-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sds): 기본 디자인 토큰 세팅 #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굳굳 고생하셨습니다. 👍👍👍
xsmall: '4px', | ||
small: '8px', | ||
medium: '16px', | ||
round: '100px', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
단순히 궁금한건데 round: '50%' 대신 '100px' 로 하는 이유가 있나여?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 이거
- 50% 하면 땡그랗게 안 될 때 있기도 하고
- 디자인 토큰에 100px로 되어 있어서
100px로 해도 되겠다 생각해서 했어유
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오호 그렇군여? 처음 알았습니다.
혹시 처음 아신 다른 분들을 위해 관련 스택오버플로우 글 툭~
다시 보니 폰트 토큰이 없던데 아직 작업 중인가여?? |
라기보다 디자이너분들이 사용하시는 특정 fontWeight만 골라서 패키지에 포함하려구 합니당 아마 타이포 해주시면서 정리될 것 같은데 타이포 컴포넌트 추가하면서 해놓을게요 🙏🏽 |
🎉 변경 사항
현재 fix된 디자인 토큰을 우선 반영합니다.
🔗 링크
🙏 여기는 꼭 봐주세요!