-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web-domains): Home Layout padding 변경, Empty View 삭제, 모임홈 디자인 정의서 업데이트 #206
Conversation
|
||
return ( | ||
<span css={{ position: 'relative', borderRadius: '50%', ...borderStyles }}> | ||
<span css={{ position: 'relative', borderRadius: '50%', border: '3px solid transparent', ...borderColorStyles }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 굳이 transparent를 추가한 이유가 있나용 ?
만약 정말 필요하다면 위 borderColorStyle
은 제거하고
<span css={{ position: 'relative', borderRadius: '50%', border: '3px solid transparent', ...borderColorStyles }}> | |
<span css={{ position: 'relative', borderRadius: borderRadiusVariants.round, border: `3px solid ${isConnetion ? color.primary500 : 'transparent'}` }}> |
도 할 수 있을 것 같고
isConnection이 되었을 때만 border를 하고 싶은거였다면 아래도 가능할 거 같아요
<span css={{ position: 'relative', borderRadius: '50%', border: '3px solid transparent', ...borderColorStyles }}> | |
<span | |
css={{ | |
position: 'relative', | |
borderRadius: borderRadiusVariants.round, | |
...(isConnection && { border: `3px solid ${colors.primary500}` }), | |
}}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
왕관 아이콘이 새롭게 추가되었는데 border 유뮤에 따라서 높이가 달려저서 transparent로 적용을 했습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아하 그럼 위에 코드로 수정하시는 거 어떤가요 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👞 반영하신 것 같이 봤는데 조아요 !
...mains/src/home/features/gather-member/components/GatherMemberProfile/GatherMemberProfile.tsx
Outdated
Show resolved
Hide resolved
7e3484a
to
95edf9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋습니다~~
🎉 변경 사항
나 자신이 포함되지 않은 프로필 리스트 -> 나 자신이 포함된 프로필 리스트로 변경
모임장 표시 관련-> 왕관 이모지 삭제하고, 왕관 아이콘을 프로필 이미지 위에 배치
손 흔들기 대기 상태 추가
🔗 링크
SAMBAD-QA1-67
SAMBAD-QA1-134
디자인 정의서 바로 보러가기
🙏 여기는 꼭 봐주세요!