fix(web-domains): 반응형 UI 수정 #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeJeongHooo
requested review from
Doeunnkimm,
semnil5202,
Andrevile and
sambad-adventure
as code owners
Doeunnkimm
reviewed
Sep 10, 2024
Comment on lines
19
to
20
| '@media (max-width: 320px)': { | ||
| marginTop: 0, |
There was a problem hiding this comment.
이거 css-utils에서 정의해서 사용하면 좋을 거 같아요.
만약 정의해서 사용하게 된다면 매번 모바일 미디어 쿼리 px을 신경쓰지 않고도 사용할 수 있을 거 같아요
const fooCss = css({
...mobileMediaQuery({
marginTop: 0
})
})There was a problem hiding this comment.
추가해봤는데.. 리뷰 부탁좀 드리겠습니다!! 도은님~~ @Doeunnkimm
packages/web-domains/src/user/common/assets/icons/OnwerCharacter.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
5
to
11
| padding: '0 20px', | ||
| paddingBottom: '100px', | ||
| marginTop: '48px', | ||
| '& > *:not(:first-of-type)': { | ||
| marginTop: '32px', | ||
| }, | ||
| }); |
packages/web-domains/src/user/features/select-user-role/containers/SelectRoleContainer.tsx
Outdated
Show resolved
Hide resolved
| color={colors.black} | ||
| css={{ | ||
| textAlign: 'center', | ||
| marginTop: '118px', |
There was a problem hiding this comment.
근데 저 궁금한게 이거 118px은 어디서 온건가요? (그냥 궁금..)
There was a problem hiding this comment.
이거 제가 핸드폰 노치까지 착각해서 잘못된 margin을 추가한 거 같습니다!! 알려주셔서 감사합니다~~
packages/web-domains/src/user/features/user-role-closing/containers/OwnerStartContainer.tsx
Outdated
Show resolved
Hide resolved
LeeJeongHooo
force-pushed
the
fix/responsive-issues
branch
from
71a884f to
924e147
Compare
LeeJeongHooo
force-pushed
the
fix/responsive-issues
branch
from
924e147 to
8ec47c4
Compare
Doeunnkimm
reviewed
Sep 11, 2024
packages/core/css-utils/src/index.ts
Outdated
| @@ -1,3 +1,4 @@ | |||
| export { getBorder } from './getBorder'; | |||
| export { getCssVar } from './getCssVar'; | |||
| export { getPadding } from './getPadding'; | |||
| export * from './getMediaQuery'; | |||
There was a problem hiding this comment.
Suggested change
| export * from './getMediaQuery'; | |
| export { mobileMediaQuery } from './getMediaQuery'; |
Doeunnkimm
reviewed
Sep 11, 2024
packages/web-domains/src/user/features/select-user-role/containers/SelectRoleContainer.tsx
Show resolved
Hide resolved
|
정호님! 혹시 다음에는 코멘트 마다 커밋 분리해서 |
semnil5202
approved these changes
Sep 13, 2024
Comment on lines
+30
to
+32
| '@media (max-width: 365px)': { | ||
| top: '64px', | ||
| }, |
There was a problem hiding this comment.
으음 mediaMobileQuery max-width를 받는게 더 좋을수도 있을 것 같아요. 저희는 이미지를 absoulte로 다루는 곳이 많아서 생각보다 365px과 같이 특정 px에서 @media 쿼리를 조정해줘야하는 일이 있을 것 같아서요.
일단 안 받는 쪽으로 진행했으니 고고하시죵.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 변경 사항
홈 네비게이션
모임 정보 입력 클로징 화면
모임 생성 성공 화면
모임 초대 화면
모임 정보 입력 폼
온보딩
입력 폼 padding 추가
padding을 추가하여 디바이스 크기에 따라 스크롤이 되도록 변경하였습니다.
🔗 링크
피그마
🙏 여기는 꼭 봐주세요!