fix: 모임원 없을 때 EmptyView 적용 #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrevile
requested review from
Doeunnkimm,
semnil5202,
LeeJeongHooo and
sambad-adventure
as code owners
semnil5202
reviewed
Sep 8, 2024
| return ( | ||
| <EmptyView | ||
| title="아직 입장한 모임원이 없어요!" | ||
| css={{ position: 'fixed', top: '50%', left: '50%', transform: 'translate(-50%,-50%)' }} |
There was a problem hiding this comment.
엇? 상위 요소에 대한 absolute가 아니고 fixed이군요?? EmptyView 위치에 딱히 이슈는 없었나요?
There was a problem hiding this comment.
@semnil5202
이거 컨텐츠가 height 100%가 안잡혀서 fixed로 한거긴한데 다시 체크해보긴 해야겠군요
semnil5202
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 변경 사항
https://www.notion.so/depromeet/Empty-View-fa7d7c09538440a9b11bd194260cf0c4?pvs=4
🔗 링크
🙏 여기는 꼭 봐주세요!