Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web-domains): 자기소개, 코멘트 validation 수정 #182

Merged
merged 2 commits into from
Aug 30, 2024
Merged

fix(web-domains): 자기소개, 코멘트 validation 수정 #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29bc70e
fix: validation 수정
LeeJeongHooo Aug 30, 2024
db943df
fix: 수정 validation
LeeJeongHooo Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/web-domains/src/answer/features/comment/components/Comment.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ export const Comment = ({ comment, onChangeComment }: CommentProps) => {
<CommentInput
value={comment}
onChange={onChangeComment}
maxLength={20}
errors={{ maxLength: 20 }}
maxLength={100}
errors={{ maxLength: 100 }}
css={{ marginTop: '24px' }}
/>
</div>
Expand Down
4 changes: 2 additions & 2 deletions packages/web-domains/src/answer/features/comment/components/CommentInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ export const CommentInput = forwardRef<HTMLInputElement, CommentInputProps>(

const handleChange = (e: React.ChangeEvent<HTMLInputElement>) => {
const { value } = e.target;
setInput(value);
onChange?.(value);
setInput(value.substring(0, maxLength));
onChange?.(value.substring(0, maxLength));
};

const handleReset = () => {
Expand Down
1 change: 1 addition & 0 deletions .../web-domains/src/new-meeting/features/get-meeting-info/components/TextField/TextField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export const TextField = forwardRef<HTMLInputElement, PropsWithChildren<InputPro
const handleChange = (event: ChangeEvent<HTMLInputElement>) => {
if (maxLength && event.target.value.length > maxLength) {
event.target.value = event.target.value.slice(0, maxLength);
return;
}
onChange && onChange(event);
};
Expand Down
4 changes: 2 additions & 2 deletions packages/web-domains/src/user/features/get-user-info/components/Form/ExtraInfoForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export const ExtraInfoForm = () => {
required: true,
minLength: 1,
maxLength: 15,
pattern: /^\S.*\S$/,
validate: (value) => (value.trim().length >= 1 ? true : false),
})}
/>
<TextInput
Expand All @@ -69,7 +69,7 @@ export const ExtraInfoForm = () => {
required: true,
minLength: 1,
maxLength: 15,
pattern: /^\S.*\S$/,
validate: (value) => (value.trim().length >= 1 ? true : false),
})}
/>
<div css={buttonWrapperCss}>
Expand Down
5 changes: 4 additions & 1 deletion packages/web-domains/src/user/features/get-user-info/components/Form/IntroInfoForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,10 @@ export const IntroInfoForm = () => {
<TextArea
maxLength={MAX_LENGTH}
placeholder="저는 이런 사람이에요"
{...register('introduction', { maxLength: MAX_LENGTH, pattern: /^\S.*\S$/ })}
{...register('introduction', {
maxLength: MAX_LENGTH,
validate: (value) => (value.trim().length >= 1 ? true : false),
})}
/>
<Txt as="p" typography="body4" color={colors.grey600}>
최대 {MAX_LENGTH}자까지 입력해주세요
Expand Down
3 changes: 2 additions & 1 deletion packages/web-domains/src/user/features/get-user-info/components/TextInput/TextArea.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ export const TextArea = forwardRef<HTMLTextAreaElement, TextAreaProps>((props, r

const handleChange = (event: ChangeEvent<HTMLTextAreaElement>) => {
if (maxLength && event.target.value.length > maxLength) {
event.target.value = event.target.value.slice(0, maxLength);
event.target.value = event.target.value.substring(0, maxLength);
return;
}
onChange && onChange(event);
};
Expand Down
1 change: 1 addition & 0 deletions packages/web-domains/src/user/features/get-user-info/components/TextInput/TextInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export const TextInput = forwardRef<HTMLInputElement, TextInputProps>((props, re
const handleChange = (event: ChangeEvent<HTMLInputElement>) => {
if (maxLength && event.target.value.length > maxLength) {
event.target.value = event.target.value.slice(0, maxLength);
return;
}
onChange && onChange(event);
};
Expand Down
5 changes: 4 additions & 1 deletion packages/web-domains/src/user/features/modify-user-info/components/ModifyIntroForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,10 @@ export const ModifyIntroForm = () => {
<TextArea
placeholder="저는 이런 사람이에요."
maxLength={MAX_LENGTH}
{...register('introduction', { maxLength: MAX_LENGTH, pattern: /^\S.*\S$/ })}
{...register('introduction', {
maxLength: MAX_LENGTH,
validate: (value) => (value.trim().length >= 1 ? true : false),
})}
/>
<Txt as="p" typography="body4" color={colors.grey600}>
최대 {MAX_LENGTH}자까지 입력해주세요
Expand Down
Loading