Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web-domains): 다음 질문인 카카오톡 공유하기 오지정 오류 해결 #120

Merged
merged 2 commits into from
Aug 25, 2024
Merged

fix(web-domains): 다음 질문인 카카오톡 공유하기 오지정 오류 해결 #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bea440d
refactor: 다음 질문인 공유 nextTarget field 추가 및 카카오 공유하기에 적용
semnil5202 Aug 21, 2024
f1066ec
refactor: 버튼 디자인 시안에 맞게 large로 적용
semnil5202 Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions packages/web-domains/src/relay-question/features/share-group/types/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
interface TargetMember {
meetingMemberId: number;
name: string;
profileImageFileUrl: string;
role: string;
}

export interface ActiveQuestionResponse {
meetingQuestionId: number;
questionImageFileUrl: string;
Expand All @@ -9,10 +16,6 @@ export interface ActiveQuestionResponse {
startTime: string;
isAnswered: boolean;
isQuestionRegistered: boolean;
targetMember: {
meetingMemberId: number;
name: string;
profileImageFileUrl: string;
role: string;
};
targetMember: TargetMember;
nextTargetMember: TargetMember;
}
6 changes: 4 additions & 2 deletions ...-next-questioner/containers/ShareNextQuestionerContainer/ShareNextQuestionerContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ export const ShareNextQuestionerContainer = () => {
다음 질문인에게 공유하기
</Button>
<Link href="/answer/opening">
<Button variant="sub">제일 먼저 답변하기</Button>
<Button variant="sub" size="large">
제일 먼저 답변하기
</Button>
</Link>
</div>
</div>
Expand All @@ -66,7 +68,7 @@ export const ShareNextQuestionerContainer = () => {
topTitle="다음 릴레이 질문인에게"
bottomTitle="공유해 보세요!"
shareImageUrl={KAKAO_IMAGE_URL}
shareDescription={`다음 질문인은 ${activeQuestion?.targetMember.name}님이에요! 현재 진행 중인 릴레이 질문이 끝나면 질문을 꼭! 생성해주세요`}
shareDescription={`다음 질문인은 ${activeQuestion?.nextTargetMember?.name || '000'}님이에요! 현재 진행 중인 릴레이 질문이 끝나면 질문을 꼭! 생성해주세요`}
shareLink={`${getWebDomain()}/answer/opening`}
/>
</>
Expand Down