fix(home, start-relay-question): 잘못된 폰트 컬러 지정 오류 수정 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semnil5202
requested review from
Doeunnkimm,
LeeJeongHooo,
Andrevile and
sambad-adventure
as code owners
LeeJeongHooo
approved these changes
Aug 20, 2024
Doeunnkimm
reviewed
Aug 21, 2024
| imageUrl={profileImageFileUrl} | ||
| width={40} | ||
| height={40} | ||
| css={{ borderRadius: '50%', objectFit: 'cover' }} |
There was a problem hiding this comment.
borderRadius도 sds에 토큰 있슴니다 ㅎㅎ !!!! 메이드 인 나..
| @@ -1,5 +1,5 @@ | |||
| import { Txt } from '@sambad/sds/components'; | |||
| import { colors, borderRadiusVariants } from '@sambad/sds/theme'; | |||
| import { borderRadiusVariants, colors } from '@sambad/sds/theme'; | |||
| import Link from 'next/link'; | |||
|
|
|||
| import { AngleRightIcon } from '../../../../../../../core/sds/src/components/Icon/assets/AngleRight'; | |||
next app router 부터 objectFit prop 대신 fill 사용을 권장(강제) 하나, 부모요소에 position 속성 반드시 필요 등, 현재 구조에서 여러 변동사항이 생겨 emotion css로 object-fit 지정
Andrevile
force-pushed
the
fix/SAMBAD-QA1-7
branch
from
ddc0766 to
6d80c9c
Compare
Andrevile
force-pushed
the
fix/SAMBAD-QA1-7
branch
from
6d80c9c to
ac0f5c4
Compare
Andrevile
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 변경 사항
https://www.notion.so/depromeet/59294244931b45d6911b6cc418143227?pvs=4
🔗 링크
🙏 여기는 꼭 봐주세요!