Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autodetect bind_addr #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

autodetect bind_addr #3

wants to merge 1 commit into from

Conversation

macton
Copy link

@macton macton commented Feb 18, 2013

If config.bind_addr is not supplied, detect public ip address and use as default value. Update demo.c to not supply bind_addr (so that, by default, demo is public facing and not on-host only.)

@deplinenoise
Copy link
Owner

While a nice feature, it's not necessary to do core webby chores. I'd like to keep it around, but put it in an optional webby_aux.c files with an associated webby_aux.h, similar to how Lua structures it's "extra" stuff that is optional.

To complete the demo application, have it use webby_aux.h to set the bind address. It would also be cool if it accepted a bind address and port from the command line, and only called the auto-detect if you didn't give it an IP.

Also a minor thing, but try to keep the patch consistent with the coding style in the rest of the project (indentation, spaces around operators).

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants