-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add npm_and_yarn
package managers' requirements to ecosystem metrics
#10977
Merged
kbukum1
merged 4 commits into
main
from
kamil/add_npm_yarn_pm_reqs_to_ecosystem_metrics
Nov 26, 2024
Merged
Add npm_and_yarn
package managers' requirements to ecosystem metrics
#10977
kbukum1
merged 4 commits into
main
from
kamil/add_npm_yarn_pm_reqs_to_ecosystem_metrics
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbukum1
commented
Nov 21, 2024
kbukum1
force-pushed
the
kamil/add_npm_yarn_pm_reqs_to_ecosystem_metrics
branch
2 times, most recently
from
November 21, 2024 01:49
5edb762
to
78740b1
Compare
update common requirements to handle min, max properly
kbukum1
force-pushed
the
kamil/add_npm_yarn_pm_reqs_to_ecosystem_metrics
branch
from
November 25, 2024 21:16
37a0210
to
8a2a7ec
Compare
common/lib/dependabot/requirement.rb
Outdated
|
||
# Methods for handling maximum constraints | ||
sig { params(version: Dependabot::Version).returns(Dependabot::Version) } | ||
def handle_lte_max(version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you write the method names in full?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is done.
abdulapopoola
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR adds the ability to extract and report package manager version constraints for
npm
,pnpm
, andyarn
from theengines
field in thepackage.json
manifest file.By including these constraints, the ecosystem metrics now provide better visibility into the range of supported package manager versions used in projects.
What issues does this affect or fix?
This PR enhances ecosystem metrics tracking for the
npm_and_yarn
ecosystem by introducing package manager version requirement collection and normalization fornpm
,pnpm
, andyarn
.Anything you want to highlight for special attention from reviewers?
engines
field to ensure it handles constraints properly fornpm
,pnpm
, andyarn
.1.3.4
into=1.3.4
.engines
field may contain incomplete or malformed version constraints.How will you know you've accomplished your goal?
npm
,pnpm
, andyarn
are correctly represented in the ecosystem metrics.engines
fields gracefully.Checklist