Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMC-19551: CLP draft promos #19640

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Oct 29, 2024

Description

Relates to #19551

Testing done

  • Manually
  • Cypress

Screenshots

QA steps

Creating CLP

  • Use the spreadsheet for testing

Editing CLP

  • Use the spreadsheet for testing

Creating benefits hub page

  • Use the spreadsheet for testing

Editing benefits hub page

  • Use the spreadsheet for testing

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  1. Do this
    • Validate that
  2. Then
    • Validate that
  3. Then validate Acceptance Criteria from issue
    • a
    • b
    • c

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 29, 2024 20:20 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 30, 2024 00:23 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 30, 2024 09:16 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 30, 2024 12:52 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 30, 2024 13:06 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 31, 2024 08:58 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 1, 2024 08:57 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 2, 2024 08:51 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 3, 2024 09:53 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 4, 2024 08:51 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 5, 2024 08:49 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 5, 2024 14:10 Destroyed
Copy link

github-actions bot commented Nov 5, 2024

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 5, 2024 20:24 Destroyed
Copy link

github-actions bot commented Nov 5, 2024

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 28, 2024 08:42 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 29, 2024 08:42 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 30, 2024 08:42 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 1, 2024 08:45 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 2, 2024 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 2, 2024 15:25 Destroyed
Copy link

github-actions bot commented Dec 2, 2024

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 2, 2024 17:08 Destroyed
Copy link

github-actions bot commented Dec 2, 2024

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 3, 2024 04:56 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 3, 2024 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 3, 2024 13:53 Destroyed
Copy link

github-actions bot commented Dec 3, 2024

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 3, 2024 15:58 Destroyed
Copy link

github-actions bot commented Dec 3, 2024

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 3, 2024 16:27 Destroyed
Copy link

github-actions bot commented Dec 3, 2024

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 3, 2024 21:38 Destroyed
Copy link

github-actions bot commented Dec 3, 2024

Checking composer.lock changes...

@va-cms-bot
Copy link
Collaborator

Cypress Accessibility Violations

/test-data-temporibus

ID: button-name
Impact: critical
Tags: cat.name-role-value, wcag2a, wcag412, section508, section508.22.a, ACT, TTv5, TT6.a
Description: Ensures buttons have discernible text
Help: Buttons must have discernible text
Nodes:

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Page introduction' field" data-proofing-help="Add an introduction that helps visitors understand if information on the page is relevant to them."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: .field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Generate a table of contents from major headings' field" data-proofing-help="By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.">
    Impact: critical
    Target: .field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Main content' field" data-proofing-help="The main body of the page, which appears below the featured content."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: button[data-proofing-help-title="About 'Main content' field"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element's default semantics were not overridden with role="none" or role="presentation"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants