Adds steps to take when updating app registry entries. #2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds steps to take when updating app registry entries.
jamigibbs
reviewed
Aug 12, 2024
| - _Add the link to your merged vets-website PR here_ | ||
|
|
||
| 2. **Changing an entryName**: First search [vets-website](https://github.com/department-of-veterans-affairs/vets-website/) for references to this `entryName` that are _not_ in the app folder (particularly in `src/applications/static-pages/static-pages-entry.js` and `src/platform/forms/constants.js`) and merge a PR that updates those references, if any. | ||
| - _Add the link to your merged vets-website PR here_ |
There was a problem hiding this comment.
Is it intentional that both deleting and changing an entryName have the same instructions for 1 and 2?
There was a problem hiding this comment.
@jamigibbs just ran across this PR, any thoughts on ^? thanks!
There was a problem hiding this comment.
@acrollet This is a blast from the past. Sorry for the delay. I probably reviewed this during my FE CoP support rotation and didn't get notified about it after I rolled off.
jamigibbs
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the PR template to add steps to take when deleting/changing registry
entryNames.Related issue(s)