fix: broken ci #694
Merged
fix: broken ci #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iable type annotation is 'any' or 'unknown'
…available in Deno 2
…ble-kv options don't work when testing)
…available in Deno 2
…rown error in promised function
This was referenced Oct 25, 2024
iuioiua
suggested changes
Oct 31, 2024
| @@ -881,6 +881,9 @@ Deno.test("[e2e] GET /account/upgrade", async (test) => { | |||
| await createUser(user); | |||
|
|
|||
| await test.step("serves internal server error response if the `STRIPE_PREMIUM_PLAN_PRICE_ID` environment variable is not set", async () => { | |||
| // Suppress the error message thrown by the handler | |||
| const stubbedError = stub(console, "error"); | |||
There was a problem hiding this comment.
Suggested change
| const stubbedError = stub(console, "error"); | |
| using stubbedError = stub(console, "error"); |
Removes the need for stubbedError.restore(); below.
There was a problem hiding this comment.
TS doesn't like it
| @@ -1,4 +1,7 @@ | |||
| // Copyright 2023-2024 the Deno authors. All rights reserved. MIT license. | |||
|
|
|||
| /// <reference lib="deno.unstable" /> | |||
There was a problem hiding this comment.
@kt3k shouldn't "unstable": ["kv"] within deno.json fix this?
There was a problem hiding this comment.
Weirdly it didn't. I see there is --unstable-kv option provided when running deno task test, but same problem. I think it could be some deno issue. I have been able to make it work only with the reference ... comment.
There was a problem hiding this comment.
Yeah, this seems like a runtime issue.
|
PTAL @kt3k |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI is broken due to various issues, in this request all issues with CI are solved.
Unfortunately I had to cherry-pick the commit 6c6399b as it was blockage.
The commands
deno task builddeno fmt --check && deno lint && deno task check:license --check && deno task check:types && deno task testwork well on Deno 1.46.3 as well as on 2.0.2
closes #693