Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: allow license check to be multiline #659

Merged
merged 1 commit into from
Jan 22, 2024
Merged

chore: allow license check to be multiline #659

merged 1 commit into from
Jan 22, 2024

Conversation

matthewford
Copy link
Contributor

@matthewford matthewford commented Jan 21, 2024 •
edited
Loading

Currently, when you add your own license to modified files, it will complain.

This changes the regex so that it can be multiline.

iuioiua
iuioiua approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to have! LGTM. Thank you.

@iuioiua iuioiua changed the title Allow license check to be multiline chore: allow license check to be multiline Jan 22, 2024
@iuioiua iuioiua merged commit 5ec7f0b into denoland:main Jan 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewford @iuioiua