Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use Array.fromAsync() #639

Merged
merged 1 commit into from
Nov 2, 2023
Merged

refactor: use Array.fromAsync() #639

merged 1 commit into from
Nov 2, 2023

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Nov 2, 2023

@iuioiua iuioiua marked this pull request as ready for review November 2, 2023 21:59
@iuioiua iuioiua merged commit d19880e into main Nov 2, 2023
4 checks passed
@iuioiua iuioiua deleted the array-from-async branch November 2, 2023 22:00
@marvinhagemeister
Copy link
Collaborator

This is currently causing 500 errors in prod. Whilst Array.fromAsync is supported in Deno CLI, it's not yet supported in Deploy.

marvinhagemeister added a commit that referenced this pull request Nov 24, 2023
@marvinhagemeister
Revert "refactor: use Array.fromAsync() (#639)"
09baa36 
This reverts commit d19880e.
@marvinhagemeister marvinhagemeister mentioned this pull request Nov 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @marvinhagemeister