Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap with mapError to catch Deno.errors.NotFound correctly #95

Merged
merged 1 commit into from
Mar 6, 2022
Merged

Wrap with mapError to catch Deno.errors.NotFound correctly #95

merged 1 commit into from
Mar 6, 2022

Conversation

hyp3rflow
Copy link
Contributor

I wrapped lstat, stat with mapError to convert node error to deno one instead of using [Symbol.hasInstance]
resolves #94

dsherret
dsherret approved these changes Mar 6, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @hyp3rflow!

@dsherret dsherret merged commit 69006cd into denoland:main Mar 6, 2022
@hyp3rflow hyp3rflow deleted the fix/stat-error branch March 7, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ensureDir cannot catch NotFound error from dntShim.lstat
2 participants
@hyp3rflow @dsherret