fix(no-control-regex): Only warn on control char literals #1340
+51
−119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1143.
Old and new behavior both diverge from ESLint but in different ways:
In all cases (including ESLint), the checking is done against the regex source string rather than the JS/TS source code. This gives the following behavior:
old
new
/�/
(literal 0x1f char)/\x1f/
new RegExp('�')
(literal 0x1f char)new RegExp('\x1f')
new RegExp('\\x1f')
Also fixes the following 2 bugs noted in the linked issue:
0x00
is rendered\x00
not\x0