Fix case sensitivity when checking TLS certificate #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #165 +/- ##
==========================================
- Coverage 89.10% 89.10% -0.01%
==========================================
Files 44 44
Lines 8095 8092 -3
==========================================
- Hits 7213 7210 -3
Misses 882 882 ☔ View full report in Codecov by Sentry. |
SAN DNS entry is not case sensitive, so ignore case of hostname. Use uppercase to preserve DNS: prefix.
michael-dev
force-pushed
the
bugfix/certificate-names-are-caseinsensitive
branch
from
5ee42a2 to
09e2f69
Compare
|
Thank you for this pull request. Can you add test coverage for this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SAN DNS entry is not case sensitive, so ignore case of hostname.
Otherwise connections might fail.