refactor: unify "Select Chat": use one component #4440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does not compile. This is a preparation for the unification of the "Select Chat" dialogs. The rename is performed in a separate commit to preserve git history. ForwardMessage is the oldest such "Select Chat" dialog, from which apparently all the other ones were copy-pasted.
WofWca
force-pushed
the
wofwca/refactor-unify-select-chat-dialogs
branch
from
9d87f02 to
23461f2
Compare
For: - webxdc `sendToChat()` - mailto dialog - "Forward Message" dialog What this commit comes down to: - Take the ForwardTo dialog and use it to create a more generic, reusable SelectChat dialog. - Make those similar dialogs use the new SelectChat component, instead of defining their markup and logic manually. The dialogs have practically the same markup and the same search logic, with very little differences. They apparently were copy-pasted from `ForwardMessage` dialog, which is the oldest of them all. It's getting pretty annoying to maintain them, with all the `RovingTabindex` and `InfiniteLoader`, so, it's about time to unify them. This is mainly a refactor, but causes a few small visual changes. For example, this fixes a small visual bug in the `WebxdcSendToChat` dialog where the search field takes full height when there are no search results.
WofWca
force-pushed
the
wofwca/refactor-unify-select-chat-dialogs
branch
from
23461f2 to
8ad414e
Compare
nicodh
approved these changes
Jan 10, 2025
|
@Simon-Laux Could you please see if you agree with the general idea of this MR? |
Simon-Laux
approved these changes
Jan 11, 2025
There was a problem hiding this comment.
Good idea. removing code without removing functionality is always good 👍
#3030 would affect all 3 dialogs, so having only one place to add contacts to is also nice for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For:
sendToChat()What this commit comes down to:
a more generic, reusable SelectChat dialog.
instead of defining their markup and logic manually.
The dialogs have practically the same markup and the same
search logic, with very little differences.
They apparently were copy-pasted from
ForwardMessagedialog,which is the oldest of them all.
It's getting pretty annoying to maintain them, with all the
RovingTabindexandInfiniteLoader, so, it's about timeto unify them.
This is mainly a refactor, but causes a few small visual changes.
For example, this fixes a small visual bug
in the
WebxdcSendToChatdialogwhere the search field takes full height
when there are no search results.