-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement: a11y: turn more elements into <button>s #4429
Conversation
WofWca
commented
Dec 19, 2024
- improvement: turn clickable items into s
- improvement: turn clickable items into s
- improvement: a11y: turn quote into
- refactor: add comment about a11y
- improvement: turn autocrypt msg into
- improvement: turn delivery status into
a28b241
to
ae0761f
Compare
ae0761f
to
3a1f270
Compare
3a1f270
to
1bd4143
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a bit weird now that the reactions and the context menu is now reachable with key navigation but only, if the cursor is on the right height to "activate" these buttons. I can activate the context menu with the "menu" button on my keyboard but I can't navigate on the menu. Is the plan to implement these missing features also?
Nevertheless this PR is an improvement and a good step. Other optimizations can follow later...
There are ways to activate "react" and the context menu with just the keyboard, so I think there is no need for the extra ways to do that with the controls that appear on hover. But this can be achieved by adding
Even with arrow keys? |
Making each message keyboard-navigable is taken care of in #4294. |
1bd4143
to
31572da
Compare
- Author name in MessageList - Author avatar in MessageList
- Join video chat - Info messages - "Show full message" (HTML)
Although I'm not quite sure if we want it to be a button when clicking on it does nothing.
31572da
to
bcb126a
Compare