Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: a11y: turn more elements into <button>s #4429

Merged
merged 8 commits into from
Jan 6, 2025

Conversation

WofWca
Copy link
Collaborator

@WofWca WofWca commented Dec 19, 2024

  • improvement: turn clickable items into s
  • improvement: turn clickable items into s
  • improvement: a11y: turn quote into
  • refactor: add comment about a11y
  • improvement: turn autocrypt msg into
  • improvement: turn delivery status into

@WofWca WofWca force-pushed the wofwca/a11y-messages-buttons branch from a28b241 to ae0761f Compare December 20, 2024 14:05
@WofWca WofWca changed the title wofwca/a11y messages buttons improvement: a11y: turn more elements into <button>s Dec 20, 2024
@WofWca WofWca marked this pull request as ready for review December 20, 2024 14:05
@WofWca WofWca force-pushed the wofwca/a11y-messages-buttons branch from ae0761f to 3a1f270 Compare December 20, 2024 15:05
@WofWca WofWca force-pushed the wofwca/a11y-messages-buttons branch from 3a1f270 to 1bd4143 Compare December 23, 2024 11:17
Copy link
Contributor

@nicodh nicodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a bit weird now that the reactions and the context menu is now reachable with key navigation but only, if the cursor is on the right height to "activate" these buttons. I can activate the context menu with the "menu" button on my keyboard but I can't navigate on the menu. Is the plan to implement these missing features also?

Nevertheless this PR is an improvement and a good step. Other optimizations can follow later...

packages/frontend/src/components/message/Message.tsx Outdated Show resolved Hide resolved
@WofWca
Copy link
Collaborator Author

WofWca commented Jan 6, 2025

the reactions and the context menu is now reachable with key navigation but only, if the cursor is on the right height to "activate" these buttons

There are ways to activate "react" and the context menu with just the keyboard, so I think there is no need for the extra ways to do that with the controls that appear on hover. But this can be achieved by adding :focus-within on top of :hover if needed.

but I can't navigate on the menu

Even with arrow keys?

@nicodh
Copy link
Contributor

nicodh commented Jan 6, 2025

the reactions and the context menu is now reachable with key navigation but only, if the cursor is on the right height to "activate" these buttons

There are ways to activate "react" and the context menu with just the keyboard, so I think there is no need for the extra ways to do that with the controls that appear on hover. But this can be achieved by adding :focus-within on top of :hover if needed.

For me it is like this:
I can focus (via tab key) to the message with the reaction
image

but the next tab jumps to the attach button in the message input field

image

I can't focus the other messages, (only when I go with the cursor near a message which makes the reactions button visible)

but I can't navigate on the ,

Even with arrow keys?
My fault, I tried tab key. Works with arrow keys.

@WofWca
Copy link
Collaborator Author

WofWca commented Jan 6, 2025

Making each message keyboard-navigable is taken care of in #4294.

@WofWca WofWca force-pushed the wofwca/a11y-messages-buttons branch from 1bd4143 to 31572da Compare January 6, 2025 18:40
- Author name in MessageList
- Author avatar in MessageList
@WofWca WofWca force-pushed the wofwca/a11y-messages-buttons branch from 31572da to bcb126a Compare January 6, 2025 18:42
@WofWca WofWca merged commit 4bf6070 into main Jan 6, 2025
11 checks passed
@WofWca WofWca deleted the wofwca/a11y-messages-buttons branch January 6, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants