feat: Emit ImexProgress(1) after receiving backup size #6347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UIs may want to display smth like "Transferring..." after "Establishing connection between devices..." on nonzero progress. Before, progress on the receiver side was starting with 2 after receiving enough data.
Simon-Laux
approved these changes
Dec 17, 2024
I tweaked the existing test and it fails w/o the change itself. |
iequidoo
force-pushed
the
iequidoo/get_backup2-progress-1
branch
from
b60f11c to
4590435
Compare
iequidoo
commented
Dec 18, 2024
| @@ -309,6 +310,10 @@ pub async fn get_backup2( | |||
| let mut file_size_buf = [0u8; 8]; | |||
| recv_stream.read_exact(&mut file_size_buf).await?; | |||
| let file_size = u64::from_be_bytes(file_size_buf); | |||
| info!(context, "Received backup file size."); | |||
There was a problem hiding this comment.
Forgot to log file_size, but anyway having some log is good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UIs may want to display smth like "Transferring..." after "Establishing connection between devices..." on nonzero progress. Before, progress on the receiver side was starting with
2after receiving enough data.