api: cffi: add dc_event_get_json which gives the jsonrpc representation of an event
#6326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion of an event This has the advantage that fields are named/labled and there can be potentially more than 2 (data1 & data2) fields on the events. This removes the need for the (potentialy confusing) overloading data1 with `dc_event_get_data1_str` to add more information to events. And also allows gradual/partial moving to the jsonrpc api, when needed or wanted.
link2xt
reviewed
Dec 10, 2024
iequidoo
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the advantage that fields are named/labled and there can be potentially more than 2 (data1 & data2) fields on the events.
This removes the need for the (potentialy confusing) overloading data1 with
dc_event_get_data1_strto add more information to events.And also allows gradual/partial moving to the jsonrpc api, when needed or wanted.
Context/intention: seems logical and was easy to add, no personal grand plan behind it, just wanted to make life easier for UI devs.
Disclaimer: haven't tested it yet, but should work as it is really simple.