test: Notifiy more prominently & in more tests about false positives when running cargo test
#6308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when running with `cargo test` This: - Moves the note about the false positive to the end of the test output, where it is more likely to be noticed - Also notes in test_modify_chat_disordered() and test_setup_contact_*(), in addition to the existing note in test_was_seen_recently()
Hocuri
changed the title
cargo testcargo test
iequidoo
approved these changes
Dec 4, 2024
| pub(crate) struct TimeShiftFalsePositiveNote; | ||
| impl Drop for TimeShiftFalsePositiveNote { | ||
| fn drop(&mut self) { | ||
| if std::thread::panicking() { |
There was a problem hiding this comment.
It may not panic at this point but return Error in some tests also, but idk how to catch that. Anyway, the proposed approach is better than the previous assert! in the only test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: