Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix panic in receive_emails benchmark #6306

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

Hocuri
Copy link
Collaborator

@Hocuri Hocuri commented Dec 2, 2024

The benchmark function (e.g. recv_all_emails()) is executed multiple times on the same context. During the second iteration, all the emails were already in the database, so, receiving them again failed.

This PR fixes that by passing in a second iteration counter that is different for every invocation of the benchmark function.

The benchmark function (e.g. `recv_all_emails()`) is executed multiple times on the same context.
During the second iteration, all the emails were already in the database, so, receiving them again failed.

This PR fixes that by passing in a second `iteration` counter that is
different for every invocation of the benchmark function.
@Hocuri Hocuri requested review from link2xt and iequidoo December 2, 2024 21:01
@Hocuri Hocuri merged commit 6468806 into main Dec 3, 2024
37 checks passed
@Hocuri Hocuri deleted the hoc/fix-receive-emails-bench branch December 3, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants