fix: replace connectivity state "Connected" with "Preparing" #6302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/connectivity-preparing
branch
from
fdcbef3 to
447a116
Compare
gerryfrancis
reviewed
Dec 2, 2024
link2xt
force-pushed
the
link2xt/connectivity-preparing
branch
3 times, most recently
from
fc4dc82 to
fc136ef
Compare
iequidoo
approved these changes
Dec 3, 2024
This better reflects that this state means we just connected and there may me work to do. This state is converted to DC_CONNECTIVITY_WORKING instead of DC_CONNECTIVITY_CONNECTED state now. Before this change when IMAP connected to the server, it switched from DC_CONNECTIVITY_NOT_CONNECTED to DC_CONNECTIVITY_CONNECTING, then to DC_CONNECTIVITY_CONNECTED (actually preparing) then to DC_CONNECTIVITY_WORKING and then to DC_CONNECTIVITY_CONNECTED again (actually idle). On fast connections this resulted in flickering "Connected" string in the status bar right before "Updating..." and on slow connections this "Connected" state before "Updating..." lasted for a while leaving the user to wonder if there are no new messages or if Delta Chat will still switch to "Updating..." before going into "Connected" state again.
link2xt
force-pushed
the
link2xt/connectivity-preparing
branch
from
fc136ef to
4a1b391
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This better reflects that this state means
we just connected and there may me work to do.
This state is converted to
DC_CONNECTIVITY_WORKINGinstead of
DC_CONNECTIVITY_CONNECTEDstate now.Before this change when IMAP connected
to the server, it switched
from DC_CONNECTIVITY_NOT_CONNECTED
to DC_CONNECTIVITY_CONNECTING,
then to DC_CONNECTIVITY_CONNECTED (actually preparing)
then to DC_CONNECTIVITY_WORKING
and then to DC_CONNECTIVITY_CONNECTED again (actually idle).
On fast connections this resulted in flickering "Connected"
string in the status bar right before "Updating..."
and on slow connections this "Connected" state
before "Updating..." lasted for a while
leaving the user to wonder if there are no new messages
or if Delta Chat will still switch to "Updating..."
before going into "Connected" state again.