Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Check that IncomingMsg isn't emitted for reactions #6257

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

iequidoo
Copy link
Collaborator

@iequidoo iequidoo commented Nov 24, 2024

See #6213 (comment) for reasoning

@iequidoo iequidoo marked this pull request as ready for review November 24, 2024 18:43
@iequidoo iequidoo requested review from r10s and Hocuri November 24, 2024 18:44
Copy link
Collaborator

@Hocuri Hocuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have a test for that now!

src/reaction.rs Show resolved Hide resolved
src/reaction.rs Show resolved Hide resolved
@iequidoo iequidoo force-pushed the iequidoo/no-IncomingMsg-for-reactions branch from c8992a2 to 99098df Compare November 25, 2024 23:51
@iequidoo iequidoo merged commit 717c18e into main Nov 25, 2024
35 checks passed
@iequidoo iequidoo deleted the iequidoo/no-IncomingMsg-for-reactions branch November 25, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants