build: update iroh to the git version
#5621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
iequidoo
reviewed
May 23, 2024
Cargo.toml
Outdated
| @@ -61,8 +61,8 @@ hickory-resolver = "0.24" | |||
| humansize = "2" | |||
| image = { version = "0.25.1", default-features=false, features = ["gif", "jpeg", "ico", "png", "pnm", "webp", "bmp"] } | |||
| iroh_old = { version = "0.4.2", default-features = false, package = "iroh"} | |||
| iroh-net = "0.16.2" | |||
| iroh-gossip = { version = "0.16.2", features = ["net"] } | |||
| iroh-net = { git = "https://github.com/n0-computer/iroh", branch="main" } | |||
There was a problem hiding this comment.
But this way things can break at any moment. Maybe specify the current HEAD commit?
There was a problem hiding this comment.
We have a lockfile for this, but yes, I can also specify rev.
link2xt
force-pushed
the
link2xt/iroh-update
branch
from
185c623 to
501969b
Compare
This fixes the problem with simultaneous connections in iroh-gossip: <n0-computer/iroh#2318>
link2xt
force-pushed
the
link2xt/iroh-update
branch
from
501969b to
a68d84b
Compare
iequidoo
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem with simultaneous connections in iroh-gossip: n0-computer/iroh#2318