Skip to content

Commit

Permalink
fix: Don't emit MsgsNoticed when a message was seen on IMAP
Browse files Browse the repository at this point in the history
`receive_imf` doesn't emit `MsgsNoticed` on receipt of an IMAP-seen message, so the code was
inconsistent. The easiest fix is to not emit `MsgsNoticed` when a message was seen on another
device, we don't want to emit `MsgsNoticed` if not all messages are seen, otherwise that removes
useful notifications from UIs and may lead to missing messages. Checking that all previous chat
messages are at least `InNoticed` looks complicated, let's not do this for now.
  • Loading branch information
iequidoo committed Jan 6, 2025
1 parent 7f7c76f commit 8037039
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/imap.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1284,7 +1284,6 @@ impl Session {
context.on_archived_chats_maybe_noticed();
}
for updated_chat_id in updated_chat_ids {
context.emit_event(EventType::MsgsNoticed(updated_chat_id));
chatlist_events::emit_chatlist_item_changed(context, updated_chat_id);
}

Expand Down

0 comments on commit 8037039

Please sign in to comment.