Remove prepareMsg (and OUT_PREPARING message state) #3468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To test the changes in this pull request, install this apk: |
Hocuri
force-pushed
the
hoc/remove-inpreparation
branch
from
364306a to
0d75504
Compare
Hocuri
force-pushed
the
hoc/remove-inpreparation
branch
from
0d75504 to
2bd1502
Compare
Hocuri
changed the title
Hocuri
changed the title
adbenitez
approved these changes
Dec 6, 2024
|
To test the changes in this pull request, install this apk: |
6 tasks
link2xt
approved these changes
Dec 7, 2024
|
isIncreation() can be removed from dc_wrapper.c and from DcMsg.java as well - it was not used recently anyways, but now soon definetely pointness and removed from core |
|
Corresponding core PR removing now unused API: deltachat/deltachat-core-rust#6319 |
Yes, right. As long as we don't get feature requests for it, I think it's fine not to have it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes prepareMsg, which put messages into the OUT_PREPARING state and was used while videos were recoded: