remove android dependencies from bindings #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
requested review from
Simon-Laux,
angelo-fuchs,
Hocuri and
cyBerta
and removed request for
cyBerta,
angelo-fuchs and
Hocuri
r10s
commented
Mar 4, 2021
|
also removed android.graphics.Color from bindings, now that should be usable standalone. |
Hocuri
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
targets deltachat-bot/echo#9
now, it should be possible to check out the android project and use only the
jniand thesrc/com/b44t/messengerdirectory in combination with plain java, without android.at some point, we could think over to move the bindings to a separate project, however, i am not in favor of doing that now as this would comes at costs wrt android development. but if it is actually in use independently of android, we can think over it.